Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Multi-User Account Sheet (IOS-245) #1273

Merged
merged 13 commits into from
Apr 30, 2024

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Apr 15, 2024

  • Replaces the PanModal-library with the iOS-formSheet (and prevents the StatusBar from flickering)
  • Adds an option to logout all accounts (only visible if more than one account, LMK what you think!)
  • Adds sliding-actions for logout
  • Uses SF Symbols (no surprises here)
  • Looks like this:

ios245

For more information, please head over to IOS-245

@zeitschlag zeitschlag self-assigned this Apr 16, 2024
@zeitschlag zeitschlag force-pushed the ios-245-multi-user-account-sheet branch from 23f40d3 to c85b778 Compare April 19, 2024 10:21
@zeitschlag zeitschlag changed the title [WIP] Multi-User Account Sheet (IOS-245) Improve Multi-User Account Sheet (IOS-245) Apr 23, 2024
@zeitschlag zeitschlag marked this pull request as ready for review April 23, 2024 10:22
@zeitschlag zeitschlag requested a review from kimar April 23, 2024 10:22
Copy link
Contributor

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -17,7 +17,6 @@
- [Nuke-FLAnimatedImage-Plugin](https://github.com/kean/Nuke-FLAnimatedImage-Plugin)
- [Nuke](https://github.com/kean/Nuke)
- [Pageboy](https://github.com/uias/Pageboy#the-basics)
- [PanModal](https://github.com/slackhq/PanModal.git)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kimar kimar merged commit c2d0701 into develop Apr 30, 2024
2 checks passed
@kimar kimar deleted the ios-245-multi-user-account-sheet branch April 30, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants