Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can’t edit profile #1244

Closed
zeitschlag opened this issue Feb 29, 2024 · 0 comments · Fixed by #1245 or #1259
Closed

Can’t edit profile #1244

zeitschlag opened this issue Feb 29, 2024 · 0 comments · Fixed by #1245 or #1259
Assignees
@zeitschlag
Milestone
2024.3

Comments

@zeitschlag
Copy link
Contributor

zeitschlag commented Feb 29, 2024 •
edited by linear bot
Loading

Steps to Reproduce the Problem

  1. Go to your own profile
  2. Tap "Edit Info"

Specifications

  • Version:
  • Platform:
@zeitschlag zeitschlag self-assigned this Feb 29, 2024
zeitschlag added a commit that referenced this issue Feb 29, 2024
@zeitschlag
Fix image-editing (#1244)
7e91458 
Probably introduced in 76304e5 and we just missed that :)
@zeitschlag zeitschlag mentioned this issue Feb 29, 2024
Merged
zeitschlag added a commit that referenced this issue Mar 1, 2024
@zeitschlag
Fix image-editing (#1244)
658e7e5 
Probably introduced in 76304e5 and we just missed that :)
zeitschlag added a commit that referenced this issue Mar 1, 2024
@zeitschlag
Removed unused property (#1244)
29db67f
zeitschlag added a commit that referenced this issue Mar 1, 2024
@zeitschlag
Removed unused property (#1244)
3da55aa
kimar pushed a commit that referenced this issue Mar 18, 2024
@zeitschlag
Fix Profile Editing (#1245)
62cc910 
* Fix image-editing (#1244)

Probably introduced in 76304e5 and we just missed that :)

* Removed unused property (#1244)

* Don't allow tapping on followers/followees when editing my profile

* Remove obsolete code

relationship-update on viewDidAppear is not needed anylonger as we use update user/relationship using notifications like in the good ol days

* Make relationship optional and use switch-pattern-matching for button-configuration

* Don't change relationship when relationship is updating

* [WIP] don't toggle, but just set booleans.
@linear linear bot reopened this Mar 19, 2024
zeitschlag added a commit that referenced this issue Mar 19, 2024
@zeitschlag
Fix Profile Editing again (IOS-239, #1244)
fc9927b 
This needs a bit of explanation, I guess, so please don't squash if possible? I didn't take into consideration, that the `ProfileViewController.viewModel` changes. And when it changes, all the combine-connections just ... disappear. This PR changes that (but probably I oversaw something again).
@zeitschlag zeitschlag linked a pull request Mar 19, 2024 that will close this issue
Fix Profile Editing again (IOS-239, #1244) #1259
Merged
zeitschlag added a commit that referenced this issue Mar 21, 2024
@zeitschlag
Fix Profile Editing again (IOS-239, #1244) (#1259)
ab39c6e 
* Fix Profile Editing again (IOS-239, #1244)

This needs a bit of explanation, I guess, so please don't squash if possible? I didn't take into consideration, that the `ProfileViewController.viewModel` changes. And when it changes, all the combine-connections just ... disappear. This PR changes that (but probably I oversaw something again).

* Disable pull to refresh for editing mode (IOS-239)

* In case of nothing change, cancel editing (IOS-239)
@zeitschlag zeitschlag added this to the 2024.3 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeitschlag zeitschlag

Labels
None yet
Projects
None yet
Milestone
2024.3
1 participant
@zeitschlag