Detect hashtag links just like the web UI does #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also note that I think it would be better to (also) detect hashtag links by matching the |
13-droid
reviewed
Jan 13, 2025
| String text=el.text(); | ||
| boolean startsWithHash=text.startsWith("#"); | ||
| Node previous=el.previousSibling(); | ||
| if(startsWithHash || previous != null && previous.text().startsWith("#")){ |
There was a problem hiding this comment.
Q: Could you expand on why the previous sibling being a hashtag makes el a hashtag?
There was a problem hiding this comment.
Yes, that's wrong, I mixed up the call. I'll fix it in a minute.
There was a problem hiding this comment.
Fixed. The line now correctly says if(startsWithHash || previous != null && previous.text().endsWith("#")){.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #959.
See https://github.com/mastodon/mastodon/blob/67a8d4638c6e6a3ef178258504a6535746608c42/app/javascript/hooks/useLinks.ts#L13-L15 for the web logic.
Please note that I did not check whether this issue also exists in the iOS app, as I didn't find the matching part of the code there.