Differentiate between “My followers” and other accounts followers for i18n #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… i18n Some languages, like german, could profit from the distinction whether a label is shown in the context of the current user's profile page or a different user's profile page. This way we can use more clear and fitting translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages, like german, could profit from the distinction whether a label is shown in the context of the current user's profile page or a different user's profile page.
This way we can use more clear and fitting translations.
This PR makes it possible to have different strings for "Posts", "Following", and "Followers" in the ProfileFragment, as well as FollowerListFragment and FollowingListFragment, depending on whether a user is currently looking at their own profile or that of another user.
This doesn't touch the UI of Profile cards in the "For You" section or in the notification area, because there we will only ever see other users profiles and never our own.