Support canceling remote commands via context. (#1) #128
Conversation
| close(command.done) | ||
| return | ||
| case <-ctxDone: |
There was a problem hiding this comment.
you can write:
case <-ctx.Done():
...There was a problem hiding this comment.
This is an optimization. We don't exit the loop here, so this would fire every iteration through the loop. With the code as it is, it only fires a single time, then we set ctxDone to nil and Close() the command.
There was a problem hiding this comment.
Ok, now it really does what I intended it to do after I pulled the definition of ctxDone out of the loop.
|
Would you mind adding a section in the README to add minimal documentation regarding the option of passing a |
Run linter and fix linter issues.
|
Hello Brice, did you have something different in mind? Anything missing? Thanks... |
Hi, sorry for my lack of answers, I was abroad with limited Internet access. |
Merge pull request masterzen#128 from kgadams/master
This solves the issue #125.