Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy Ottehr customization #841

Open
wants to merge 56 commits into
base: develop
Choose a base branch
from
Open

Conversation

AykhanAhmadli
Copy link
Contributor

No description provided.

@AykhanAhmadli AykhanAhmadli marked this pull request as ready for review January 29, 2025 19:33
@VladMstv
Copy link
Collaborator

@alexwillingham should we have PROJECT_NAME_UPPER upper variations? I think it should be written in the same way everywhere across the project like "Ottehr" without any upper and lower case transformations

@alexwillingham
Copy link
Contributor

More of a product question to review places that is used and whether it looks ok?

@alexwillingham
Copy link
Contributor

Should https://docs.oystehr.com/ottehr/customization/theming/ get a nice update as this merges?

@AykhanAhmadli
Copy link
Contributor Author

AykhanAhmadli commented Feb 20, 2025

@VladMstv is right I think, I didn't want to remove uppercase ones before anyone's approval but I think it is outdated since we don't have an abbreviation or short name for Ottehr.

I can update the customization oystehr docs after merging this one.

@VladMstv
Copy link
Collaborator

so @alexwillingham for example if company name is "A.B.C. Care" - I doubt they'll want it "A.b.c. care" somewhere or in all uppercase letters

@alexwillingham
Copy link
Contributor

so @alexwillingham for example if company name is "A.B.C. Care" - I doubt they'll want it "A.b.c. care" somewhere or in all uppercase letters

probably so, but we should continue to take small steps. seems OK to merge without addressing this one further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants