Alex/more zambdas cleanup #1645
Conversation
…das and fix chooseJson
apps/ehr/src/api/api.ts
Outdated
| @@ -47,8 +47,8 @@ const GET_PATIENT_PROFILE_PHOTO_URL_ZAMBDA_ID = import.meta.env.VITE_APP_GET_PAT | |||
| const SAVE_PATIENT_FOLLOWUP_ZAMBDA_ID = import.meta.env.VITE_APP_SAVE_PATIENT_FOLLOWUP_ZAMBDA_ID; | |||
| const CREATE_LAB_ORDER_ZAMBDA_ID = import.meta.env.VITE_APP_CREATE_LAB_ORDER_ZAMBDA_ID; | |||
|
|
|||
| function chooseJson(json: any, isLocal: string): any { | |||
| return isLocal === 'true' ? json : json.output; | |||
| export function chooseJson(json: any): any { | |||
There was a problem hiding this comment.
Maybe it can be renamed now to something like this?
| export function chooseJson(json: any): any { | |
| export function getZambdaOutput(json: any): any { |
There was a problem hiding this comment.
also this function can be moved to utils and then we can remove duplicate from apps/intake/src/api/zapehrApi.ts
There was a problem hiding this comment.
This function should actually be removed entirely, but there is a tweak needed in the SDK. This function is serving the purpose of casting json.output to any because the SDK has a bug that has the type on zambda execute result being string. When that is fixed, we can delete this function and wherever it was used just inline json.output. So I'll come back through to remove this function soon entirely enough.
There was a problem hiding this comment.
i went ahead and consolidated to just one of those functions, in utils.
No description provided.