fix automated confirmation messages not sending #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbenham
reviewed
Mar 26, 2025
packages/zambdas/src/patient/appointment/prebook-create-appointment/index.ts
Outdated
Show resolved
Hide resolved
imbenham
reviewed
Mar 26, 2025
| @@ -251,6 +254,23 @@ export async function createAppointment( | |||
| } | |||
|
|
|||
| console.log('success, here is the id: ', appointment.id); | |||
|
|
|||
| // this is done after the performTransactionalFhirRequests because it needs the appointment id | |||
There was a problem hiding this comment.
Note that you can reference an intra-batch-created resource via the fullUrl property. Maybe you wanted to include this post with the rest of the transactional writes?
There was a problem hiding this comment.
i had no idea this was a thing. thank you! 1216023
There was a problem hiding this comment.
Yep, just note there is some possibility of a bug where subscriptions can be improperly invoked mid-transaction, causing some expected supporting resources to be missing when the subscription handler is run. I believe we've resolved to fix that bug before it reaches production, but is something I think I should flag here all the same.
imbenham
reviewed
Mar 26, 2025
packages/zambdas/src/patient/subscriptions/task/sub-confirmation-messages/index.ts
Outdated
Show resolved
Hide resolved
imbenham
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1239