GRPC provider - Main.2.5 #742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Coverage report for experimental massa-web3
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success134 tests passing in 15 suites. Report generated by 🧪jest coverage report action from 94f326e |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
peterjah
reviewed
Mar 17, 2025
peterjah
reviewed
Mar 17, 2025
peterjah
reviewed
Mar 17, 2025
peterjah
reviewed
Mar 17, 2025
src/smartContracts/smartContract.ts
Outdated
| @@ -64,7 +64,7 @@ export class SmartContract { | |||
| target: this.address, | |||
| ...options, | |||
| } | |||
| return this.provider.readSC(readParams) | |||
| return this.provider.readSC(readParams) as Promise<ReadSCData> | |||
There was a problem hiding this comment.
this cast could be removed if addressing the previous comment
There was a problem hiding this comment.
so we can remove the cast ? ^^
peterjah
reviewed
Mar 17, 2025
Comment on lines
+8
to
+21
| describe('Provider GRPC tests', () => { | ||
| test('getNodeStatus', async () => { | ||
| const status = (await grpcProvider.getNodeStatus()) as PublicStatus | ||
| expect(status.getConfig()).toBeDefined() | ||
| expect(status.getCurrentCycle()).toBeDefined() | ||
| expect(status.getCurrentTime()).toBeDefined() | ||
| expect(status.getCurrentCycleTime()).toBeDefined() | ||
| expect(status.getLastExecutedFinalSlot()).toBeDefined() | ||
| expect(status.getLastExecutedSpeculativeSlot()).toBeDefined() | ||
| expect(status.getFinalStateFingerprint()).toBeDefined() | ||
| expect(status.getChainId()).toBeDefined() | ||
| expect(status.getMinimalFees()).toBeDefined() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
It would be nice to have more tests. I suggest to put them in a dedicated file. this can be done in a followup issue
peterjah
reviewed
Mar 28, 2025
peterjah
requested changes
Mar 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.