Remove several sources of non-determinism #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gterzian
force-pushed
the
disbale_threads_wasm
branch
4 times, most recently
from
0723c30 to
c54d4f3
Compare
|
@damip fixed an import error, and added a stack check and turned-off simd. Looking into the failling tests... |
gterzian
force-pushed
the
disbale_threads_wasm
branch
from
c54d4f3 to
10deac2
Compare
gterzian
force-pushed
the
disbale_threads_wasm
branch
from
bc72471 to
313f47a
Compare
|
Also needed to turn off the "on by default", |
gterzian
changed the title
Eitu33
reviewed
Apr 11, 2022
gterzian
force-pushed
the
disbale_threads_wasm
branch
from
313f47a to
00b93ef
Compare
Eitu33
approved these changes
Apr 11, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For determinism: #94