Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to AndroidX #463

Merged
merged 5 commits into from
Oct 19, 2018
Merged

Migrate to AndroidX #463

merged 5 commits into from
Oct 19, 2018

Conversation

k-kagurazaka
Copy link
Member

fix #447

Now Orma only supports AndroidX instead of Android Support Library.

@k-kagurazaka k-kagurazaka self-assigned this Oct 18, 2018
@k-kagurazaka
Copy link
Member Author

Hmm..., this is weird 🤔
Local CircleCI build succeeds in my Mac.

@chibatching
Copy link
Contributor

Maybe, android.useAndroidX=true is needed on ./gradle.properties but this repository doesn't contained it.

@k-kagurazaka
Copy link
Member Author

@chibatching Thanks! You are right 😄

@k-kagurazaka k-kagurazaka requested a review from gfx October 18, 2018 05:41
gfx
gfx reviewed Oct 18, 2018
View reviewed changes
build.gradle
SUPPORT_LIBRARY_VERSION = '28.0.0'
ANDROIDX_CORE_VERSION = '1.0.0'
ANDROIDX_ANNOTATION_VERSION = '1.0.0'
ANDROIDX_RECYCLERVIEW_VERSION = '1.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Should we specify each version instead of the single ANDROIDX_VERSION?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.android.com/jetpack/androidx/androidx-rn

It seems that AndroidX is a set of libraries that have the only one version, so ANDROIDX_VERSION seems enough.

Copy link
Member Author

@k-kagurazaka k-kagurazaka Oct 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndroidX starts semantic versioning per library.
( See Per-artifact strict semantic versioning section in this article )

Currently, all artifacts have the same version but it will be different in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! okay!

@gfx
Copy link
Member

gfx commented Oct 19, 2018

LGTM.

@k-kagurazaka Can you merge it and release a new version, v6.0.0?

@k-kagurazaka
Copy link
Member Author

I got it 👍

@k-kagurazaka k-kagurazaka merged commit 1561d21 into master Oct 19, 2018
@k-kagurazaka k-kagurazaka deleted the androidx branch October 19, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfx gfx gfx left review comments

Assignees

@k-kagurazaka k-kagurazaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AndroidX support
3 participants
@k-kagurazaka @chibatching @gfx