porting-primitives #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamariyan
force-pushed
the
primitives
branch
4 times, most recently
from
610b1f0 to
302873e
Compare
maryamariyan
force-pushed
the
primitives
branch
from
302873e to
4cdca7b
Compare
…otnet#31892) * Using new custom target from arcade * removing the outerbuild directory
This is the only one in the repo still using a number.
Based on JanV's suggestions and based on my own composite R2R work I have made a few small improvements in R2RDump: 1) When normalization is on, we newly also normalize transition records for a particular IP address. 2) New option --hide-transitions suppresses transition information in the disassembly completely. 3) Logic for parsing the new OwnerCompositeExecutable R2R section. Thanks Tomas
* Update dependencies from https://github.com/dotnet/arcade build 20200210.11 - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20110.11 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20110.11 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20110.11 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20110.11 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20110.11 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20110.11 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20110.11 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20110.11 - Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20110.11 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20110.11 - Microsoft.DotNet.GenAPI - 5.0.0-beta.20110.11 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20110.11 - Microsoft.DotNet.GenFacades - 5.0.0-beta.20110.11 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20110.11 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20110.11 * Update dependencies from https://github.com/dotnet/arcade build 20200211.3 - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20111.3 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20111.3 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20111.3 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20111.3 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20111.3 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20111.3 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20111.3 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20111.3 - Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20111.3 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20111.3 - Microsoft.DotNet.GenAPI - 5.0.0-beta.20111.3 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20111.3 - Microsoft.DotNet.GenFacades - 5.0.0-beta.20111.3 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20111.3 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20111.3 * Update dependencies from https://github.com/dotnet/arcade build 20200211.5 - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20111.5 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20111.5 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20111.5 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20111.5 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20111.5 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20111.5 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20111.5 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20111.5 - Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20111.5 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20111.5 - Microsoft.DotNet.GenAPI - 5.0.0-beta.20111.5 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20111.5 - Microsoft.DotNet.GenFacades - 5.0.0-beta.20111.5 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20111.5 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20111.5 * React to changes from dotnet/arcade#4799 * Downgrade compiler version * Update dependencies from https://github.com/dotnet/arcade build 20200211.11 - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20111.11 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20111.11 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20111.11 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20111.11 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20111.11 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20111.11 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20111.11 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20111.11 - Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20111.11 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20111.11 - Microsoft.DotNet.GenAPI - 5.0.0-beta.20111.11 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20111.11 - Microsoft.DotNet.GenFacades - 5.0.0-beta.20111.11 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20111.11 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20111.11 * Disable serialization test on Mono Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Viktor Hofer <[email protected]>
dotnet#2098) This change is motivated on two main fronts. The first is maintainability - the current managed implementation is difficult to understand and I worry diagnosing any potential issues would be a massive time sink. The second is performance - the current implementation appears to suffer from significant lock contention when running the TechEmpower plaintext benchmark. My hope is that the simpler, cleaner native implementation here will avoid both problems, but I don't want to merge it until we have benchmarking data. However, even if the numbers are similar, I still think it's worth merging just from a maintainability perspective. The native LifoSemaphore implementation has only ever been tested on posix-like platforms, so Windows behavior is unknown. Currently the Windows implementation of LowLevelLifoSemaphore is very different, so unless we have need for the LifoSemaphore elsewhere in the runtime this isn't a concern. Many thanks to @filipnavara for the initial implementation.
* remove dead code from SslStream * add equivalent ThrowIfExceptionalOrNotAuthenticated
This is a fixed version of the reverted commit. This change enables printing stack trace at stack overflow to the console. In case multiple threads fail with stack overflow in parallel, only the trace of the first thread is printed. There are couple of interesting details: The stack trace is printed in a compressed form. The algorithm finds the largest sequence of frames starting from the top of the stack that is repeated and prints it just once with the repeat count. Only the first thread that hits stack overflow gets its stack printed. On Linux, others threads that hit stack overflow are held spinning until the process exits. This enables having a single preallocated stack for handling stack overflow. On Windows, we just don't print the stack trace, as it would be messy anyways due to the interleaving of output from multiple threads and the value of getting stack overflow traces of multiple threads is questionable. On debug / checked builds for Windows, I had to bump the stack guarantee by two pages and also enable setting the stack guarantee for all threads in these build flavors. At couple of places in the runtime, there were debug checks comparing explicit frame and some other struct addresses to the current SP. These were firing on Linux when we are running on an extra stack overflow handling stack. I've fixed it by adding a flag to the Thread that indicates that we are running on an alternate stack and these checks should be skipped. I've fixed the x86 Windows JIT_StackProbe to first probe at SP-4 and then move the SP to leave more stack space for the handler. I've fixed stack overflow check on Linux for some glibc / distros. The stack limit returned by the pthread_attr_getstack returns the address of the guard page in some of the glibc / distros and address of the last accessible page before the guard page on others. So I've relaxed the check to consider +/- 1 page around the stack limit to recognize sigsegv as stack overflow.
…otnet#31957) * Implement the JIT part of the dynamic dictionary expansion feature. * review response. * response review
* Add Process.WaitForExitAsync() and associated unit tests Add a task-based `WaitForExitAsync()` for the `Process` class, and duplicate existing `WaitForExit()` tests to add async versions. In order to ensure that the `Exited` event is never lost, it is the callers responsibility to ensure that `EnableRaisingEvents` is `true` _prior_ to calling `WaitForExitAsync()`. A new `InvalidOperationException` is introduced to enforce those semantics. * Review feedback: Change WaitForExitAsync to return Task Per review feedback, change `WaitForExitAsync` to return a `Task` instead of `Task<bool>`. Now, to determine if the process has exited, callers should check `HasExited` after the await, and cancellation follows the async pattern of setting canceled on the task. * Remove asserts on Task properties Per code review feedback, remove the asserts that verify that the Task returned by WaitForExitAsync is completed successfully / canceled, as they're essentially Task tests and not relevant to WaitForExitAsync. * Fix unit test to not create async void Per code review feedback, fix the MultipleProcesses_ParallelStartKillWaitAsync test to make work a `Func<Task>` instead of an `Action` since we're await-ing it. * Remove implicit delegate creation for ExitHandler Per code review feedback, converting ExitHandler from a local function to an `EventHandler` to avoid the extra delegate allocation to convert between the types. * Flow CancellationToken to OperationCanceledExceptions Per code review, register the `TaskCompletionSource` with the `CancellationToken` so that if an `OperationCanceledException` is thrown the relevant token is available on `OperationCanceledException.CancellationToken`. To accomplish that the `TaskCompletionSourceWithCancellation` class that's internal to `System.Net.Http` is moved to Common and consumed in both places. Unit tests are also updated to verify that the cancellation token passed in is the same one returned from `OperationCanceledException.CancellationToken`. * Do not require EnableRaisingEvents to already be true Per code review feedback, update `WaitForExitAsync` to not require the user to call `EnableRaisingEvents` first. Setting `EnableRaisingEvents` ourselves introduces the chance for an exception in the case where the process has already exited, so I've added a comment to the top of the method to detail the possible paths through the code and added comment annotations for each case. Lastly, I updated the unit tests to remove `EnableRaisingEvents` calls. * Follow style guidelines in ProcessWaitingTests Per code review feedback, update the new unit tests in ProcessWaitingTests to follow style guidelines. * Update tests to follow coding guidelines Per code review feedback, update tests to follow coding guidelines, simplify creating cancellation tokens, and verify synchronous completion of tasks in the exited / canceled case. * Update WaitForExitAsync to early out in canceled case Per code review feedback, add an early out for a non-exited process when canceled. * Add a test for completion without a cancellation token Per code review feedback, add a test for a process that completes normally and doesn't use a canellation token. * Address PR feedback in xmldocs Per code review feedback, update the xmldocs for `WaitForExitAsync` to specify the language keyword for "true", and add a `<returns>` element. * Update xmldocs per code review feedback Per code review feedback, update xmldocs to list other conditions that can cause the function to return. * Update function guards per code review feedback Per code review feedback, update the method guards to span multiple lines to adhere to style guidelines. * Refactor test to verify async as well as sync cancellation Per code review feedback, update SingleProcess_TryWaitAsyncMultipleTimesBeforeCompleting to test both the case where the token is canceled before creating the Task as well as after the task is already created.
* Add span-based methods to Decimal * Address PR feedback Add missing tests * Address PR feedback
This change adds the new command-line option "--composite", a new type of input files "--unrooted-input-file" for files that should be made part of the composite image but only rooted as hit by the dependency analysis, not automatically as the normal input files (to reduce the size of framework built along with the app) and new Crossgen2 logic for producing the additional R2R metadata needed by composite images including rewriting of input MSIL by injecting a "component R2R header" on them that forwards the native code to the composite image. With a set of runtime changes out for a separate PR I'm able to make first steps in running composite R2R in the CoreCLR runtime. Thanks Tomas
* Remove the commented code * Remove unused nint/nuint aliases from PNSE version of Utf8String
…on when request times out (dotnet#2281) Currently, HttpClient throws the same TaskCancellationException regardless of the request cancellation reason that can be caller's cancellation, all pending request cancellation or timeout. This makes it impossible to handle a request timeout in a way different from all other cases (e.g. special retry logic). This PR adds a timeout detection logic into HttpClient. It watches for all TaskCancelledExceptions and catches the one caused by timeout. Then, it creates two new exceptions and build a hierarchy. The first is a TimeoutException having its InnerException set to the original TaskCancelledException. The second is a new TaskCancelledException having its InnerException set to that new TimeoutException, but preserving the original stack trace, message and cancellation token. Finally, this top-level TaskCancelledException gets thrown. Fixes dotnet#21965
) * Ensure ActiveIssue attribute is only used with issue links The constructor that takes an `int` was removed in dotnet/arcade#4831. Update docs to recommend using issue links instead of numbers. Fix two tests that were using ActiveIssue incorrectly. * PR feedback
… more. (dotnet#32532) Co-authored-by: Zoltan Varga <[email protected]>
This includes some other minor cleanup to the netcore hosting functions. Setting `assemblies_path` with `APP_PATHS` despite it also being set by `MONO_PATH` doesn't scare me too much because: 1) Anyone using `MONO_PATH` is probably not going through the hosting API and is using `mono-sgen` directly 2) The default host doesn't set `APP_PATHS` unless `Microsoft.NETCore.DotNetHostPolicy.SetAppPaths` is set to 1 in the `.runtimeconfig.json` (which is rare, and we've worked fine without `APP_PATHS` being set at all up until now) 3) This is a temporary measure; we will have to refactor our preload hook when we want to properly support the other loader properties anyway
* Update docs for steps to take if CI fails * update * more * more * more * include dumps * more * more * typo
…et#32556) Fixes a crash with AOT because domain->setup is NULL here
We never track the value of locals who have their address taken in a method, since their value can change without the pass detecting it, leading to propagation of incorrect values. We failed to check for this when doing a stloc.np optimization. Fixes System.Reflection.Metadata.Tests.ImmutableByteArrayInteropTest.DangerousCreateFromUnderlyingArray Enable more interp tests, which don't seem to fail on my machine. Co-authored-by: Vlad Brezae <[email protected]>
…32537) The managed allocator included in a full aot image does not support canaries, leading to inconsistent object layout. Fixes mono/mono#18925 Co-authored-by: Vlad Brezae <[email protected]>
…functions don't need safepoints. (dotnet#32215) Co-authored-by: Zoltan Varga <[email protected]>
This change attempts to fix a non-deterministic customer reported failure. Several customers have observed failure during resource update when the HostModel updates the AppHost (to transfer resources from the managed app). The failure is not detereminisitc, not reproducible on our machines, and depends on specific computers/software running. This indicates interference by other software while the HostWriter is updating the AppHost. The current implementation retries the resource update if an update because the device or drive is locked (say by an antivurus) HRESULT 0x21 and 0x6C. However, the failures reported have errors 0x5 (Access violation) and 0x6# (Open failed). Windows/Defender team said that file-locking with these error-codes is not expected. However, different AVs work differently about examining files. We believe that the correct fix for this issue is to complete: To implement dotnet#3828 and dotnet#3829 Ship AppHost with an extension/permissions not indicating an executable. However the above is a fairly large change for servicing .net core 3.1. So, this change implements a simpler fix intended for servicing 3.1 branch: Always retry the resource-update on Win32 error, unless the failure is a knwon irrecoverable code (listed a few error codes relevent to File IO). This change may cause unnecessary retries on legitimate failures (about 50 seconds). But such cases are rare, because the SDK supplies the apphost, and the HostModel itself creates the file to update. Fixes dotnet#3832
The real goal is to make it not recursive. This is just a step along the way. Note that the actual not-recursive change has *not* yet been developed, so this *might* amount to nothing useful. Co-authored-by: Jay Krell <[email protected]>
* Change COMPlus_DiagnosticsServerTransportPath to DOTNET_DiagnosticsServerAddress
There were a bunch of backedge and build-only dependencies in here that should be moved to the toolset category. Also fix a few darc verify errors
- Find references (ILSpy) - Fix for all target frameworks (NC and NS2.1) - Add shared file (todo: move to common) - (todo: reduce NoWarn items) - (Remove extra blank lines)
[Todo] - Fix full path - Test package location - Verify strong name - Plan for PreReleaseVersionLabel in version.props
- TODO: add pkg folder too
maryamariyan
force-pushed
the
primitives
branch
from
c8ef8cf to
3d9a40d
Compare
maryamariyan
pushed a commit
that referenced
this pull request
May 27, 2021
…tnet#52769) Transition to GC Unsafe mode on every MONO_RT_EXTERNAL_ONLY function in reflection.c In particular, fix mono_reflection_type_from_name which is used in https://github.com/xamarin/xamarin-android/blob/681887ebdbd192ce7ce1cd02221d4939599ba762/src/monodroid/jni/embedded-assemblies.cc#L350 Fixes stack traces like ``` 05-14 08:06:12.848 31274 31274 F DEBUG : #00 pc 00000b99 [vdso] (__kernel_vsyscall+9) 05-14 08:06:12.848 31274 31274 F DEBUG : #1 pc 0005ad68 /apex/com.android.runtime/lib/bionic/libc.so (syscall+40) (BuildId: 6e3a0180fa6637b68c0d181c343e6806) 05-14 08:06:12.848 31274 31274 F DEBUG : #2 pc 00076511 /apex/com.android.runtime/lib/bionic/libc.so (abort+209) (BuildId: 6e3a0180fa6637b68c0d181c343e6806) 05-14 08:06:12.848 31274 31274 F DEBUG : #3 pc 0002afcd /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonodroid.so (xamarin::android::internal::MonodroidRuntime::mono_log_handler(char const*, char const*, char const*, int, void*)+141) (BuildId: 9726f32ad5f8fa5e7c5762baf2f6e3294da41cc1) 05-14 08:06:12.848 31274 31274 F DEBUG : #4 pc 00112c5d /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (eglib_log_adapter+141) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #5 pc 00020fdf /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (monoeg_g_logv+175) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #6 pc 0002113a /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (monoeg_g_log+42) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #7 pc 00128892 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_threads_transition_do_blocking+258) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #8 pc 0012a406 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_threads_enter_gc_safe_region_unbalanced_with_info+134) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #9 pc 0012a27e /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_threads_enter_gc_safe_region_internal+46) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #10 pc 000799a7 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_loader_lock+71) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #11 pc 000447a1 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_class_create_from_typedef+129) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #12 pc 0003c073 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_class_get_checked+99) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #13 pc 0003cc0f /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_class_from_name_checked_aux+735) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #14 pc 00037989 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_class_from_name_checked+73) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #15 pc 000cc5f4 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_reflection_get_type_internal+132) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #16 pc 000c9bce /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_reflection_get_type_with_rootimage+126) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #17 pc 000ca204 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (_mono_reflection_get_type_from_info+292) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #18 pc 000ca06e /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_reflection_type_from_name_checked+334) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #19 pc 000c9f01 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonosgen-2.0.so (mono_reflection_type_from_name+49) (BuildId: b67e93dd750dafdd6f65f408b021b6a3a74868ac) 05-14 08:06:12.849 31274 31274 F DEBUG : #20 pc 0001b40b /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonodroid.so (xamarin::android::internal::EmbeddedAssemblies::typemap_java_to_managed(char const*)+427) (BuildId: 9726f32ad5f8fa5e7c5762baf2f6e3294da41cc1) 05-14 08:06:12.849 31274 31274 F DEBUG : #21 pc 0001b551 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonodroid.so (xamarin::android::internal::EmbeddedAssemblies::typemap_java_to_managed(_MonoString*)+113) (BuildId: 9726f32ad5f8fa5e7c5762baf2f6e3294da41cc1) 05-14 08:06:12.849 31274 31274 F DEBUG : #22 pc 000211a7 /data/app/~~rMrkpKmVPaBpM5jKb8fPAg==/com.microsoft.maui-JfRo8RWSDJaNtJuBa0y7_Q==/lib/x86/libmonodroid.so (xamarin::android::internal::MonodroidRuntime::typemap_java_to_managed(_MonoString*)+39) (BuildId: 9726f32ad5f8fa5e7c5762baf2f6e3294da41cc1) ```
maryamariyan
pushed a commit
that referenced
this pull request
May 27, 2021
…2915) * [build] Define NO_UNALIGNED_ACCESS for 32-bit arm platforms Possibly related to crashes on Android like this: ``` 05-18 10:59:07.466 17076 17076 F libc : Fatal signal 7 (SIGBUS), code 1 (BUS_ADRALN), fault addr 0xb9c95a41 in tid 17076 (simplehellomaui), pid 17076 (simplehellomaui) 05-18 10:59:07.501 17104 17104 I crash_dump32: obtaining output fd from tombstoned, type: kDebuggerdTombstone 05-18 10:59:07.502 989 989 I tombstoned: received crash request for pid 17076 05-18 10:59:07.503 17104 17104 I crash_dump32: performing dump of process 17076 (target tid = 17076) 05-18 10:59:07.512 17104 17104 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 05-18 10:59:07.512 17104 17104 F DEBUG : Build fingerprint: 'google/crosshatch/crosshatch:11/RQ2A.210405.005/7181113:user/release-keys' 05-18 10:59:07.512 17104 17104 F DEBUG : Revision: 'MP1.0' 05-18 10:59:07.512 17104 17104 F DEBUG : ABI: 'arm' 05-18 10:59:07.515 17104 17104 F DEBUG : Timestamp: 2021-05-18 10:59:07+0200 05-18 10:59:07.515 17104 17104 F DEBUG : pid: 17076, tid: 17076, name: simplehellomaui >>> com.microsoft.simplehellomaui <<< 05-18 10:59:07.515 17104 17104 F DEBUG : uid: 10364 05-18 10:59:07.515 17104 17104 F DEBUG : signal 7 (SIGBUS), code 1 (BUS_ADRALN), fault addr 0xb9c95a41 05-18 10:59:07.515 17104 17104 F DEBUG : r0 bb4a5cd0 r1 b9c95a49 r2 00000000 r3 e94c7520 05-18 10:59:07.515 17104 17104 F DEBUG : r4 0000000c r5 00000000 r6 ff843c50 r7 ff843e70 05-18 10:59:07.515 17104 17104 F DEBUG : r8 b69547f8 r9 e99eac50 r10 00000000 r11 00000021 05-18 10:59:07.515 17104 17104 F DEBUG : ip e94c74f0 sp ff843c48 lr bb31e0dd pc bb3a4d24 05-18 10:59:07.531 709 709 E Layer : [Surface(name=Task=1)/@0x52e6b1a - animation-leash#0] No local sync point found 05-18 10:59:07.532 709 709 E Layer : [Surface(name=Task=1571)/@0x9c90165 - animation-leash#0] No local sync point found 05-18 10:59:07.706 17104 17104 F DEBUG : backtrace: 05-18 10:59:07.707 17104 17104 F DEBUG : #00 pc 000ddd24 /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mono_method_to_ir+9232) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #1 pc 000d7777 /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (inline_method+622) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #2 pc 000ec0a3 /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mono_method_to_ir+67470) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #3 pc 000cda6d /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mini_method_compile+2264) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #4 pc 000cf413 /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mono_jit_compile_method_inner+50) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #5 pc 000d1d7f /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mono_jit_compile_method_with_opt+1766) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #6 pc 0012d94d /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (common_call_trampoline+832) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #7 pc 0012d5cb /data/app/~~J4DFQ3c1v2YGrEurX7TNjg==/com.microsoft.simplehellomaui-_jGGPiZpZ3yT-QCTNDcgvQ==/lib/arm/libmonosgen-2.0.so (mono_magic_trampoline+62) (BuildId: d0a4e41a500357a621884b64f6ca8533b62a664b) 05-18 10:59:07.707 17104 17104 F DEBUG : #8 pc 0000006a <anonymous:b7986000> ``` * move to host/target sections
maryamariyan
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Initial implementation for contract customization fix build errors Move converter rooting to DefaultJsonTypeInfoResolver so that it can be used standalone Fix ConfigurationList.IsReadOnly Minor refactorings (#1) * Makes the following changes: * Move singleton initialization for DefaultTypeInfoResolver behind a static property. * Consolidate JsonSerializerContext & IJsonTypeInfoResolver values to a single field. * Move reflection fallback logic away from JsonSerializerContext and into JsonSerializerOptions * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs * remove testing of removed field Simplify the JsonTypeInfo.CreateObject implemenetation (#2) * Simplify the JsonTypeInfo.CreateObject implemenetation * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.cs * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.cs Co-authored-by: Krzysztof Wicher <[email protected]> Co-authored-by: Krzysztof Wicher <[email protected]> Tests and fixes for JsonTypeInfoKind.None TypeInfo type mismatch tests Allow setting NumberHandling on JsonTypeInfoKind.None test resolver returning wrong type of options JsonTypeInfo/JsonPropertyInfo mutability tests rename test file Move default converter rooting responsibility behind DefaultJsonTypeInfoResolver (#3) * Move default converter rooting responsibility behind DefaultJsonTypeInfoResolver * address feedback Add simple test for using JsonTypeInfo<T> with APIs directly taking it fix and tests for untyped/typed CreateObject uncomment test cases, remove todo More tests and tiny fixes Add a JsonTypeInfoResolver.Combine test for JsonSerializerContext (#4) * Fix JsonTypeInfoResolver.Combine for JsonSerializerContext * Break up failing test Fix simple scenarios for combining contexts (#6) * Fix simple scenarios for combining contexts * feedback JsonSerializerContext combine test with different camel casing Remove unneeded virtual calls & branching when accessing Get & Set delegates (#7) JsonPropertyInfo tests everything minus ShouldSerialize & NumberHandling Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs throw InvalidOperationException rather than ArgumentNullException for source gen when PropertyInfo.Name is assigned through JsonPropertyInfoValues tests for duplicated property names and JsonPropertyInfo.NumberHandling Add tests for NumberHandling and failing tests for ShouldSerialize disable the failing test and add extra checks disable remainder of the failing ShouldSerialize tests, fix working one Fix ShouldSerialize and IgnoreCondition interop Add failing tests for CreateObject + parametrized constructors Fix CreateObject support for JsonConstructor types (#10) * Fix CreateObject support for JsonConstructor types * address feedback Make contexts more combinator friendly (#9) * Make contexts more combinator friendly * remove converter cache * redesign test to account for JsonConstructorAttribute * Combine unit tests * address feedback * Add acceptance tests for DataContract attributes & Specified pattern (#11) * Add private field serialization acceptance test (#13) * tests, PR feedback (#14) * PR feedback and extra tests * Shorten class name, remove incorrect check (not true for polimorphic cases) * Make parameter matching for custom properties map property Name with parameter (#16) * Test static initialization with JsonTypeInfo (#17) * Fix test failures and proper fix this time (#18) * Fix test failures and proper fix this time * reinstate ActiveIssueAttribute * PR feedback and adjust couple of tests which don't set TypeInfoResolver * fix IAsyncEnumerable tests * Lock JsonSerializerOptions in JsonTypeInfo.EnsureConfigured() Co-authored-by: Eirik Tsarpalis <[email protected]> Co-authored-by: Eirik Tsarpalis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flat copy Primitives into runtime repo
Renames test folder to tests
Header license update on cs files
Fix compile for ref project
Fix compile for src project
- Find references (ILSpy)
- Fix for all target frameworks (NC and NS2.1)
- Add shared file (todo: move to common)
- (Remove extra blank lines)
[TODO]
- reduce NoWarn items)
Fix compile for test project
setup packaging
- Add IsAspNetCoreApp to get separate packaging path
[TODO]
- Fix full path
- Verify package in specified location
- Verify strong name
- Use PreReleaseVersionLabel in version.props
Add solution file
[TODO]:
- add pkg folder too