Skip to content

fix(stateless-tabs-view): solving accessibility order issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinLaubenstein merged 1 commit into from
Jan 7, 2026
Merged

fix(stateless-tabs-view): solving accessibility order issue #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code/core/src/components/components/Tabs/StatelessTabsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ export const StatelessTabsView: FC<StatelessTabsViewProps> = ({
justifyContent: 'space-between',
paddingInlineStart: 0,
paddingInlineEnd: 10,
// A11y: the tools must be before the tab list in the DOM for correct tab order.
// A11y: the tab list must be before the tools in the DOM for correct tab order.
// This lets us control order without adding a wrapper div, leading to better flex
// behavior on tools for our callees (e.g. containerType: 'inline-size' in a11y-addon).
'> *:not(:last-child)': {
'> *:not(:first-child)': {
order: 2,
},
'> *': {
Expand All @@ -78,8 +78,8 @@ export const StatelessTabsView: FC<StatelessTabsViewProps> = ({
gap: 0,
}}
>
{tools}
{hasContent ? tabListChild : <div />}
{tools}
</Bar>
{hasContent ? tabPanelChildren : EmptyContent}
</Container>
Expand Down