Buck review changes.

martonp · Mar 23, 2024 · ddf4cbf · ddf4cbf
1 parent dc90406
commit ddf4cbf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/client/asset/btc/btc.go b/client/asset/btc/btc.go
@@ -828,7 +828,7 @@ type baseWallet struct {
 
 	// subprocessWg must be incremented every time the wallet starts a
 	// goroutine that will use node or the tx history DB.
-	subprocessWg *sync.WaitGroup
+	subprocessWg sync.WaitGroup
 }
 
 func (w *baseWallet) fallbackFeeRate() uint64 {
@@ -1263,7 +1263,6 @@ func newUnconnectedWallet(cfg *BTCCloneCFG, walletCfg *WalletConfig) (*baseWalle
 		pendingTxs:        make(map[chainhash.Hash]ExtendedWalletTx),
 		walletDir:         walletDir,
 		ar:                addressRecyler,
-		subprocessWg:      new(sync.WaitGroup),
 	}
 	w.cfgV.Store(baseCfg)
 

diff --git a/client/asset/dcr/dcr.go b/client/asset/dcr/dcr.go
@@ -692,7 +692,7 @@ type ExchangeWallet struct {
 
 	// subprocessWg must be incremented every time the wallet starts a
 	// goroutine that will use node or the tx history DB.
-	subprocessWg *sync.WaitGroup
+	subprocessWg sync.WaitGroup
 }
 
 func (dcr *ExchangeWallet) config() *exchangeWalletConfig {
@@ -768,12 +768,6 @@ func NewWallet(cfg *asset.WalletConfig, logger dex.Logger, network dex.Network)
 		if err != nil {
 			return nil, err
 		}
-		path := filepath.Join(cfg.DataDir, chainParams.Name, "txhistory.db")
-		txHistoryDB, err := btc.NewBadgerTxDB(path, dcr.log.SubLogger("TXHISTORYDB"))
-		if err != nil {
-			return nil, fmt.Errorf("failed to create tx history db: %v", err)
-		}
-		dcr.txHistoryDB.Store(txHistoryDB)
 	default:
 		makeCustomWallet, ok := customWalletConstructors[cfg.Type]
 		if !ok {
@@ -857,7 +851,6 @@ func unconnectedWallet(cfg *asset.WalletConfig, dcrCfg *walletConfig, chainParam
 		subsidyCache:        blockchain.NewSubsidyCache(chainParams),
 		pendingTxs:          make(map[chainhash.Hash]*btc.ExtendedWalletTx),
 		walletDir:           dir,
-		subprocessWg:        new(sync.WaitGroup),
 	}
 
 	if b, err := os.ReadFile(vspFilepath); err == nil {

diff --git a/client/asset/eth/eth.go b/client/asset/eth/eth.go
@@ -434,7 +434,7 @@ type baseWallet struct {
 
 	// subprocessWg must be incremented every time the wallet starts a
 	// goroutine that will use node or the tx history DB.
-	subprocessWg *sync.WaitGroup
+	subprocessWg sync.WaitGroup
 }
 
 // assetWallet is a wallet backend for Ethereum and Eth tokens. The backend is
@@ -709,7 +709,6 @@ func NewEVMWallet(cfg *EVMWalletConfig) (w *ETHWallet, err error) {
 		pendingTxs:   make(map[uint64]*extendedWalletTx),
 		// Can be empty
 		multiBalanceAddress: cfg.MultiBalAddress,
-		subprocessWg:        new(sync.WaitGroup),
 	}
 
 	var maxSwapGas, maxRedeemGas uint64