Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libc++ compatibility by checking for <experimental/memory_resource> #57

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

justusranvier
Copy link
Contributor

Until LLVM 16 is released, and until Android and Apple platforms incorporate the forthcoming std::pmr support in their forks of libc++, this workaround is needed to use pmr containers on those platforms.

@justusranvier
Copy link
Contributor Author

Those CI check results are unfortunate. I can easily fix the clang-format issue but making the pmr unit test pass on macos would involve some pretty intrusive changes.

In my project I have to jump through several hoops to get pmr working on macos. It basically involves creating an alias for every pmr type and use the preprocessor to make sure they resolve to the correct namespace.

@martinus
Copy link
Owner

martinus commented Jan 7, 2023

I'm fine with you just #ifdef-ing the test out for macos, e.g. add something to the condition of
#if ANKERL_UNORDERED_DENSE_PMR in pmr.cpp. Not sure though how to detect macos

Until LLVM 16 is released, and until Android and Apple platforms
incorporate the forthcoming std::pmr support in their forks of libc++,
this workaround is needed to use pmr containers on those platforms.
@martinus martinus merged commit 2d8a192 into martinus:main Jan 7, 2023
@martinus
Copy link
Owner

martinus commented Jan 7, 2023

Thanks for your contribution!

@martinus
Copy link
Owner

martinus commented Jan 7, 2023

I created a new release v3.0.2 with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants