dont resize in emplace when not necessary #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert occurs This required a few refactorings. Most importantly, a newly constructed map now allocates an empty bucket array. This might cause slowdowns when you create lots of maps without ever inserting anything. The advantage is that try_emplace should have the same speed, or even be a bit faster; especially when no insertion happens.
martinus
deleted the
2023-12-dont-resize-in-emplace-when-not-necessary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98. This changes the behavior of unordered_dense:
operator[], ortry_emplacedoesn't increase size when the element is found. Basically I had to shift anifto another place, so performance wise there shouldn't be much of a difference. Maybe it's even faster.