Add MinGW support #1540
Add MinGW support #1540
Conversation
|
Hi, thanks. I will try to verify that this works and will merge eventually. |
| paths << QCoreApplication::applicationDirPath() + QDir::separator() + QL1S("plugins"); | ||
| #else | ||
| paths << QCoreApplication::applicationDirPath() + QDir::separator() + QL1S("..") + QDir::separator() + |
There was a problem hiding this comment.
Well, let me step in here.
The location of RSS Guard runtime plugins must be the same on the particular OS regardless of which toolkit was used to compile the application.
While it makes sense to have plugins in Linux-like folder hierarchy on Linux, I do not want it on Windows.
There was a problem hiding this comment.
Ah.. that is unfortunate :( because the MSYS2 team will surely patch it back to FHS, downstream
There was a problem hiding this comment.
Wait, could you come to my discord channel to discuss this?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok.. will ping you afterwards.. :)
| return QDir::toNativeSeparators(applicationDirPath() + QDir::separator() + QSL("data%1").arg(major_version)); | ||
| #else |
There was a problem hiding this comment.
Same, like my another commentary, the folder on Windows must be the same, no matter which compiler is used to compile the app.
| @@ -31,15 +31,15 @@ DKEY Node::ID = "nodejs"; | |||
|
|
|||
| DKEY Node::NodeJsExecutable = QSL("nodejs_executable_") + OS_ID; | |||
|
|
|||
| #if defined(Q_OS_WIN) || defined(Q_OS_OS2) | |||
| #if (defined(Q_OS_WIN) && defined(_MSC_VER)) || defined(Q_OS_OS2) | |||
There was a problem hiding this comment.
No, this is not really needed and in fact would break things. MinGW compiled programs still have .exe suffix...
There was a problem hiding this comment.
On MSYS2 environments, node.exe MUST be invoked through winpty.exe, else it won't work, hence the use of shell script here
| @@ -55,6 +55,8 @@ if(WIN32) | |||
| ) | |||
| elseif(OS2) | |||
| install(TARGETS app DESTINATION .) | |||
| elseif(MINGW) | |||
There was a problem hiding this comment.
Same opinion, the final application file/folder layout must be the same, regardless of used compiler. I do not want any subfolders etc.
| install(TARGETS rssguard DESTINATION .) | ||
| set(HEADERS_FOLDER "include/librssguard") | ||
| elseif(MINGW) |
There was a problem hiding this comment.
The final application file/folder layout must be the same, regardless of used compiler. I do not want any subfolders etc.
| install(TARGETS ${plugin_target_name} DESTINATION plugins) | ||
| elseif(MINGW) |
There was a problem hiding this comment.
Respect the original intended folder for plugins on Windows OS. This change is not needed nor wanted.
martinrotter
added
the
Type-Deployment
|
Thank you! |
No description provided.