Add TimeProvider #912
Merged
Add TimeProvider #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR!
Could you add a test like this one that validates the use of the user-specified TimeProvider?
Let me know what difficulties you're having building things, and I can see if there's anything I need to fix, otherwise I should be able to give some pointers.
I managed to get everything running properly and I should be able to do everything on my own now, but something urgent came up, I might need a few days before I can get back on this PR. Thank you, Martin 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 98.57% 98.59% +0.01%
==========================================
Files 16 16
Lines 281 284 +3
Branches 36 37 +1
==========================================
+ Hits 277 280 +3
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
May 21, 2025
|
Thanks for persevering with this PR. I'll look to get a new release out with this change either today or later this week. |
|
Since working on a PR like this was kind of a new experience for me, thank you very much for your patience and kindness. |
|
Thanks for your contribution @fiotti - the changes from this pull request have been published as part of version 0.6.0 📦, which is now available from NuGet.org 🚀 |
This was referenced Aug 5, 2025
This was referenced Aug 18, 2025
peggy-quartech
added a commit
to bcgov/PSSG-SPDBT
that referenced
this pull request
Aug 27, 2025
Updated [MartinCostello.Logging.XUnit](https://github.com/martincostello/xunit-logging) from 0.5.1 to 0.6.0. <details> <summary>Release notes</summary> _Sourced from [MartinCostello.Logging.XUnit's releases](https://github.com/martincostello/xunit-logging/releases)._ ## 0.6.0 ## What's Changed * Refactor build workflow by @martincostello in martincostello/xunit-logging#838 * Use lint-actions-powershell by @martincostello in martincostello/xunit-logging#843 * Add annotations for pwsh lint by @martincostello in martincostello/xunit-logging#844 * Update README with logging and DI examples by @paulomorgado in martincostello/xunit-logging#861 * Use BuildKit by @martincostello in martincostello/xunit-logging#870 * Add Public API analyzers by @martincostello in martincostello/xunit-logging#874 * Add test analytics by @martincostello in martincostello/xunit-logging#901 * Add output examples by @martincostello in martincostello/xunit-logging#917 * Add TimeProvider by @fiotti in martincostello/xunit-logging#912 ## New Contributors * @paulomorgado made their first contribution in martincostello/xunit-logging#861 * @fiotti made their first contribution in martincostello/xunit-logging#912 **Full Changelog**: martincostello/xunit-logging@v0.5.1...v0.6.0 Commits viewable in [compare view](martincostello/xunit-logging@v0.5.1...v0.6.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peggy <[email protected]>
This was referenced Oct 24, 2025
This was referenced Nov 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for the
TimeProvider(closes #911).