-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove mackup dependency #44
Conversation
- use more straightforward logic for bootstrapping and unboostrapping - mackup is broken and there are no signs of a fix - see: lra/mackup#1924 lra/mackup#2035
Reviewer's Guide by SourceryThis PR removes the mackup dependency and replaces it with a more straightforward approach to managing dotfiles. The implementation introduces two new functions ( Sequence diagram for dotfile management processsequenceDiagram
actor User
participant Script
participant HomeDirectory
User->>Script: Run bootstrap.sh
alt Unlink files
Script->>HomeDirectory: Restore files from linkme/
else Link files
Script->>HomeDirectory: Create directories from linkme/
Script->>HomeDirectory: Symlink files from linkme/
end
Script->>HomeDirectory: Source .zprofile
Class diagram for updated bootstrap functionsclassDiagram
class BootstrapScript {
+dotlink()
+dotunlink()
}
note for BootstrapScript "Replaces mackup dependency with custom functions"
class HomeDirectory {
+createDirectory(path)
+symlinkFile(source, target)
+restoreFile(source, target)
}
BootstrapScript --> HomeDirectory
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of
git pull origin main
from bootstrap.sh changes the update behavior - was this intentional? You might want to document this change if it was deliberate.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Remove the mackup dependency and implement custom logic for managing dotfiles and application settings using new functions 'dotlink' and 'dotunlink'. Update scripts to use rsync for copying files and managing symbolic links.
New Features:
Enhancements: