Fix obscure segfault when --logfile option used. #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the --logfile option but specify a filename that will be created in a directory that is not writable, for instance, a system directory such as /proc/sys/ or your current directory happens to be a system directory that you are running nwipe from while not specifying a writable path for the log file then nwipe would exit with a segfault. This is now fixed and if the logfile cannot be created or opened then an appropriate message is displayed and nwipe is aborted.
PartialVolume
deleted the
fix_segfault_when_logfile_cannot_be_created_due_to_permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the --logfile option but specify a filename
that will be created in a directory that is not writable,
for instance, a system directory such as /proc/sys/ or
your current directory happens to be a system directory
that you are running nwipe from while not specifying a
writable path for the log file then nwipe would exit with
a segfault.
This is now fixed. If the logfile cannot be created
or opened, then a appropriate message is displayed and
nwipe is aborted.