Allow Last Pass Verify to work without requiring final blanking (zero) pass. #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Allows zero fill to be verified when blanking off. Prior to this if you wanted to verify a zero pass, blanking had to be on. This meant a zero pass, then a blanking pass then a verify, effectively two zero passes and a verify. This is now fixed so you can now do a zero pass with verification without a blanking pass. This knocks a third off the wipe time of a zero fill with verification. This also means all other methods can have either all their passes or just the last pass verified without blanking being enabled. 2. OPS2 method requires the last pass to be random, the GUI now disables the use of the blanking option for this message and displays a warning message that a final blanking pass is not allowed for OPS2. It never did a final blanking pass anyway, even if it was selected, but this makes it clearer in the GUI. 3. The caculate_round_size() function was improved by reducing some duplicated code and bring the full calculation into this function. 4. On completion of each pass or verification the total number of bytes written or read for each pass or verification is logged.
PartialVolume
deleted the
Enable_verification_on_zero_pass_without_additional_blanking_pass
branch
This was referenced Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows zero fill to be verified when blanking off. Prior to this if you wanted to verify a zero pass, blanking had to be on. This meant a zero pass, then a blanking pass then a verify, effectively two zero passes and a verify. This is now fixed so you can now do a zero pass with verification without a blanking pass. This knocks a third off the wipe time of a zero fill with verification !. This also means all other methods can have either all their passes or just the last pass verified, whether static or random, without blanking being enabled. Optionally a blanking pass with or without verification can be selected except for the Ops2 method which requires a mandatory random pass.
OPS2 method requires the last pass to be random, the GUI now disables the use of the blanking option for this method and displays a warning message that a final blanking pass is not allowed for OPS2. It never did a final blanking pass anyway, even if it was selected, but this makes it clearer in the GUI that a blanking pass is not an option.
The calculate_round_size() function was improved by reducing some duplicated code and bringing the full calculation into this function. Corrected OPS2 and HMG IS5 Enhanced 'additional calculations' due to verification being allowed without a final blanking pass.
On completion of each pass or verification the total number of bytes written or read for each pass or verification is logged.
Verified correct round size and thus correct percentage completion values for all 84 possible combinations of wipe.