Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py #2653

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

skanda890
Copy link
Contributor

@skanda890 skanda890 commented Aug 22, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.

Create .deepsource.toml and .whitesource to check for security issues and more.


skanda890 and others added 4 commits August 22, 2024 16:23
…ormatter and Yapf (#38)

This commit fixes the style issues introduced in 98c9793 according to the output
from Autopep8, Black, dotnet-format, isort, Ruff Formatter and Yapf.

Details: None

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@skanda890
Copy link
Contributor Author

@marticliment, please review this and give some suggestions.

@marticliment
Copy link
Owner

please do not autoformat code

@skanda890 skanda890 marked this pull request as draft August 22, 2024 12:53
@skanda890 skanda890 changed the title Create .deepsource.toml and more Create .deepsource.toml Aug 22, 2024
@skanda890 skanda890 marked this pull request as ready for review August 22, 2024 13:46
skanda890 and others added 2 commits August 22, 2024 19:25
Co-authored-by: mend-bolt-for-github[bot] <42819689+mend-bolt-for-github[bot]@users.noreply.github.com>
@skanda890 skanda890 changed the title Create .deepsource.toml Create .deepsource.toml and .whitsource Aug 22, 2024
@skanda890 skanda890 changed the title Create .deepsource.toml and .whitsource Create .deepsource.toml and .whitesource Aug 22, 2024
@skanda890
Copy link
Contributor Author

skanda890 commented Aug 23, 2024

@marticliment, any more suggestions?

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained `in` it instead of checking for equality against each of the values.
This is faster, less verbose, and more readable.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@skanda890 skanda890 changed the title Create .deepsource.toml and .whitesource Create .deepsource.toml, .whitesource, and Update WebBasedData/test_urls.py Aug 23, 2024
@marticliment
Copy link
Owner

Why the refractoring?

@marticliment
Copy link
Owner

What do this files ( .deepsource.toml, .whitesource) do?

@skanda890
Copy link
Contributor Author

Why the refractoring?

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values. This is faster, less verbose, and more readable.

@skanda890
Copy link
Contributor Author

What do this files ( .deepsource.toml, .whitesource) do?

These files configure security bots like MendBolt and DeepSource.

@skanda890
Copy link
Contributor Author

@marticliment, please accept or deny this as soon as possible as I am deleting all my forked repositories.

@marticliment
Copy link
Owner

Give me one week

@marticliment marticliment merged commit 2bc5948 into marticliment:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants