Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bundle file is saved with file extension (fix #2618) #2625

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

gnerkus
Copy link
Contributor

@gnerkus gnerkus commented Aug 12, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.

  • fetch the user's file type selection
  • if no list of file types, default to .json

Closes #2618

@marticliment
Copy link
Owner

Looks good for me, I will test it out later this month and merge it

@marticliment
Copy link
Owner

Don't worry about merging main into your branch, I will do this when testing the PR

@gnerkus
Copy link
Contributor Author

gnerkus commented Aug 21, 2024

Don't worry about merging main into your branch, I will do this when testing the PR

Got it.

@marticliment marticliment merged commit c8f1f9b into marticliment:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bundles can be saved without file extension
2 participants