Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and CONTRIBUTING.md #2560

Merged
merged 23 commits into from
Aug 2, 2024
Merged

Conversation

skanda890
Copy link
Contributor

@skanda890 skanda890 commented Jul 31, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. Thank you for your understanding.

Update README.md and CONTRIBUTING.md


@Lockszmith-GH
Copy link

Not a maintainer, never contributed, but I have to say the language changes OP submitted are not beneficial in any way.
The language added seems more convoluted, and unnecessarily verbose.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@marticliment
Copy link
Owner

You should have the option to do it yourself

image

@skanda890 skanda890 marked this pull request as draft July 31, 2024 15:59
@skanda890 skanda890 changed the title Update README.md and CONTRIBUTING.md Update README.md Aug 1, 2024
@skanda890 skanda890 marked this pull request as ready for review August 1, 2024 10:13
@skanda890 skanda890 changed the title Update README.md Update README.md and CONTRIBUTING.md Aug 1, 2024
@skanda890
Copy link
Contributor Author

I have made some new changes, so please review them.

Copy link

@Lockszmith-GH Lockszmith-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall much better, I've added a few comments about new additions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
marticliment
marticliment previously approved these changes Aug 1, 2024
@marticliment marticliment merged commit dd9bca9 into marticliment:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants