Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple loading and "holding" packages from the UI - Creation of PackageLoaders #2328

Merged
merged 22 commits into from
Jun 23, 2024

Conversation

marticliment
Copy link
Owner

@marticliment marticliment commented Jun 19, 2024

  • Decouple loading and "storing" packages from the UI. This task will be handled by a new class named PackageLoader, whose task will be loading the packages and handling their lifecycle.
  • Transition the navigator into a instanceless, type-driven navigation experience.

Direct consequences of this change:

  • Ability to delete UI Pages when not focused without having to reload Packages from the Managers each time. This will allow for deletion of Page Instances when on background and (theoretically) substantially decrease the RAM Usage, as well as the CPU usage.
  • Better integration with the API
  • Better interop across package pages and package operations.
  • Expected better performance for loading Corresponding packages across pages

TODO:

  • Fix searching for packages on the Discover Packages tab

@marticliment marticliment changed the title Decouple loading and "storing" packages from the UI Decouple loading and "holding" packages from the UI - Creation of PackageLoaders Jun 19, 2024
@marticliment marticliment marked this pull request as ready for review June 23, 2024 09:41
@marticliment marticliment merged commit 3bd3971 into main Jun 23, 2024
3 checks passed
@marticliment marticliment deleted the decouple-ui-from-package-loaders branch July 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] (high cpu cycles)
1 participant