Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System-wide WingetUI installation #1246

Merged
merged 5 commits into from
Jul 30, 2023
Merged

System-wide WingetUI installation #1246

merged 5 commits into from
Jul 30, 2023

Conversation

marticliment
Copy link
Owner

Due to the integration of .net code (more migration will be done soon) and some incompatiblities with winget.exe, future versions of WingetUI will require a path that does not contain non-ascii characters. To achieve so, WingetUI will now be installed to the "Program Files" folder.

However, as discussed in some issues on this same issue, some components (a.k.a. choco-cli) require to be located on non-admin writeable locations, hence why WingetUI was previously installed in a per-user basis.
This is why the WingetUI installation has been split into two parts:

  • One placed under Program Files, providing the core code of WingetUI and all the components that don't require write access
  • One located under %localappdata%\Programs\WingetUI, containing the chocolatey files and future components that may require administrator rights.

This change will fix all the issues with .net crashing WingetUI due to null pointers, as well as "Permission denied" issues.
Furthermore, will add increased security, since core components will require administrator rights to be modified.

NOTE: Users without administrator privileges will be able to still use a portable installation.

NOTE: Portable installations will work as usual. If a portable installation is done, user-based components will be extracted alongside with WingetUI in the desired directory

fix #1226
fix #1229
fix #1230
fix #1239
fix #1245

fix #1222
fix #1125

related to #712 - This change increases .net compatibility, which will allow substantial winget improvements

@marticliment marticliment merged commit c286a45 into main Jul 30, 2023
@marticliment marticliment deleted the new-install-location branch October 10, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant