Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many Option #2271

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Many Option #2271

wants to merge 1 commit into from

Conversation

deckar01
Copy link
Member

Allow declaring that a schema expects a collection by default.

Resolves #2270

@lafrech
Copy link
Member

lafrech commented May 24, 2024

LGTM.

Not that it really matters but I think I'd test the whole payload rather than just the length. I mean I see no reason not to.

Just a nitpick. We can merge as is.

Thanks.

@deckar01
Copy link
Member Author

I should probably note that I have advocated for Field to adopt the load()/dump() interface to solve this use case in the past, but this solution being so simple and covering the most practical use case kept me from beating that drum again. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting many=True through Meta - SchemaOpts
2 participants
@deckar01 @lafrech