Speedup mars deserialization by __new__ #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
changed the title
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit b2b7dc6)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit b2b7dc6)
aresnow1
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit b2b7dc6)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit b2b7dc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR remove unecessary default values packing/unpacking/set and descriptor call in mars deserialization to speedup mars deserialization by about 1X times at most.
Related issue number
Fixes #xxxx
Check code requirements