Fix tensor frexp #3259
Merged
Fix tensor frexp #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2022 10:40
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Sep 22, 2022
* Fix tensor frexp * Test for Ray DAG * Fix Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 8e0d0e6)
UranusSeven
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Sep 22, 2022
* Fix tensor frexp * Test for Ray DAG * Fix Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 8e0d0e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The
numpy.frexpwrites to theout1,out2ifout1,out2are passed as input args. e.g.numpy.frexp(x, out1, out2). But, almost all the cases that theout1andout2are got from the shared memory, then theout1andout2are immutable. So, this PR usesout1, out2 = numpy.frexp(x)instead ofnumpy.frexp(x, out1, out2).Related issue number
Fixes #3257
Check code requirements