Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimization rule memory leak #3246

Merged

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

OptimizationRule has a cache that referenced optimized graphs. This PR removes the global cache.

Related issue number

Fixes #3192

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Sep 8, 2022
@fyrestone fyrestone marked this pull request as ready for review September 8, 2022 11:13
@fyrestone fyrestone requested a review from a team as a code owner September 8, 2022 11:13
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 5ab5cad into mars-project:master Sep 14, 2022
qianduoduo0904 pushed a commit to qianduoduo0904/mars that referenced this pull request Sep 22, 2022
UranusSeven pushed a commit to xorbitsai/mars that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] supervisor memory leak
3 participants