[Shuffle] isolate mappers in different subtasks for fetch_by_index mode #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
changed the title
chaokunyang
force-pushed
the
isolated_mapper_in_subtask
branch
from
036c9dd
to
02847bc
Compare
fyrestone
approved these changes
Sep 5, 2022
zhongchun
approved these changes
Sep 5, 2022
aresnow1
pushed a commit
to aresnow1/mars
that referenced
this pull request
Sep 7, 2022
…de (mars-project#3239) * ensure every subtask contains only at most one mapper * enable test_align_execution * fix isolate mappers for `DataFrameIndexAlign` which are not mappers (cherry picked from commit ee152b6)
2 tasks
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Sep 22, 2022
…de (mars-project#3239) * ensure every subtask contains only at most one mapper * enable test_align_execution * fix isolate mappers for `DataFrameIndexAlign` which are not mappers (cherry picked from commit ee152b6)
UranusSeven
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Sep 22, 2022
…de (mars-project#3239) * ensure every subtask contains only at most one mapper * enable test_align_execution * fix isolate mappers for `DataFrameIndexAlign` which are not mappers (cherry picked from commit ee152b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Mars coloring-based fusion algorithm may fuse multiple mapper subtasks of different shuffles into one subtask, which conflict with
ShuffleFetchType.FETCH_BY_INDEXshuffle block resolution mode. InShuffleFetchType.FETCH_BY_INDEXshuffle block resolution mode, shuffle data is resolved by index. If one subtask contains shuffle mapper of different shuffle, current resolution mode won't work.One solution is adding second-level index to
ShuffleManagerto work around this. It's complicated and not compatible with push-based shuffle and other shuffle system such as CloudShuffleService、alibaba/RemoteShuffleService、Firestorm.Considering very little shuffle operands will be fused into the same subtask(currently only
DataFrameIndexAlignmappers of different shuffle are fused into one subtask). We can just change the fuse algorithm to make those mappers isolated with each other into different subtasks.For other shuffle operands, there won’t be any change in the generated subtask graph.
Related issue number
Fixes #3226
#2719
#2916
Check code requirements