Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versionner compatibility with PEP600 #3223

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented Aug 12, 2022

What do these changes do?

This PR fixes versioneer compatibility with PEP600

Related issue number

pypa/setuptools#3504

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang requested a review from a team as a code owner August 12, 2022 07:08
@chaokunyang chaokunyang force-pushed the fix_versionner_pep660 branch 3 times, most recently from bcd7f1f to 4bdfba2 Compare August 12, 2022 07:23
@chaokunyang chaokunyang reopened this Aug 15, 2022
@chaokunyang chaokunyang changed the title Workaround versionner compatibility with PEP600 Fix versionner compatibility with PEP600 Aug 15, 2022
Copy link
Collaborator

@yuyiming yuyiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chaokunyang chaokunyang merged commit 43a51e2 into mars-project:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants