Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray] RayExecutionContext.get_chunk_meta from meta service #3212

Merged

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented Aug 9, 2022

What do these changes do?

To make the auto merge chunk feature works, Ray context should get meta from meta service if the key does not exist in current context.

Related issue number

Fixes #3211
Fixes #3220

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Aug 9, 2022
@fyrestone fyrestone added this to In Progress in Ray DAG Execution Backend via automation Aug 9, 2022
@fyrestone fyrestone changed the title [Ray] RayExecutionContext.get_chunk_meta across stages [Ray] RayExecutionContext.get_chunk_meta from meta service Aug 9, 2022
@fyrestone fyrestone marked this pull request as ready for review August 10, 2022 06:02
@fyrestone fyrestone requested a review from a team as a code owner August 10, 2022 06:02
@fyrestone fyrestone force-pushed the ray_get_chunk_meta_across_stages branch from 56eed0b to ea1e78e Compare August 11, 2022 10:30
ci/reload-env.sh Outdated Show resolved Hide resolved
@fyrestone fyrestone force-pushed the ray_get_chunk_meta_across_stages branch from 7ef02d7 to 39d8a44 Compare August 18, 2022 03:55
chaokunyang
chaokunyang previously approved these changes Aug 18, 2022
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LICENSE Show resolved Hide resolved
mars/tests/test_session.py Show resolved Hide resolved
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 33990d6 into mars-project:master Aug 19, 2022
Ray DAG Execution Backend automation moved this from In Progress to Done Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants