-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray] RayExecutionContext.get_chunk_meta from meta service #3212
Merged
chaokunyang
merged 13 commits into
mars-project:master
from
fyrestone:ray_get_chunk_meta_across_stages
Aug 19, 2022
Merged
[Ray] RayExecutionContext.get_chunk_meta from meta service #3212
chaokunyang
merged 13 commits into
mars-project:master
from
fyrestone:ray_get_chunk_meta_across_stages
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
changed the title
[Ray] RayExecutionContext.get_chunk_meta across stages
[Ray] RayExecutionContext.get_chunk_meta from meta service
Aug 9, 2022
fyrestone
force-pushed
the
ray_get_chunk_meta_across_stages
branch
from
August 11, 2022 10:30
56eed0b
to
ea1e78e
Compare
chaokunyang
reviewed
Aug 18, 2022
fyrestone
force-pushed
the
ray_get_chunk_meta_across_stages
branch
from
August 18, 2022 03:55
7ef02d7
to
39d8a44
Compare
chaokunyang
previously approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhongchun
reviewed
Aug 18, 2022
zhongchun
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
chaokunyang
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
To make the auto merge chunk feature works, Ray context should get meta from meta service if the key does not exist in current context.
Related issue number
Fixes #3211
Fixes #3220
Check code requirements