Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine apply key generation #3208

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Refine apply key generation #3208

merged 6 commits into from
Aug 9, 2022

Conversation

chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented Aug 8, 2022 •
edited
Loading

What do these changes do?

This PR add func key cache to avoid duplicate func serialization when generate apply key which will be costly when func capture some big objects

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang requested a review from a team as a code owner August 8, 2022 03:36
zhongchun
zhongchun previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fyrestone
fyrestone reviewed Aug 9, 2022
View reviewed changes
mars/utils.py Outdated Show resolved Hide resolved
fyrestone
fyrestone approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhongchun
zhongchun approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chaokunyang chaokunyang merged commit 1a660f5 into mars-project:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongchun zhongchun zhongchun approved these changes

@fyrestone fyrestone fyrestone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chaokunyang @zhongchun @fyrestone @hekaisheng