Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ray] Fix flaky test test_optional_supervisor_node #3133

Merged

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

test_optional_supervisor_node use same actor name for different run which is flaky because ray kill actor async. This PR fix it by using a standalone ray cluster

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang requested a review from a team as a code owner June 10, 2022 09:01
@wjsi wjsi changed the title [Ray] fix test_optional_supervisor_node flaky [Ray] Fix flaky test test_optional_supervisor_node Jun 10, 2022
@wjsi wjsi added type: tests mod: ray integration to be backported Indicate that the PR need to be backported to stable branch labels Jun 10, 2022
@wjsi wjsi added this to In Progress in Ray DAG Execution Backend via automation Jun 10, 2022
@wjsi wjsi added this to PR-In progress in v0.10 Release via automation Jun 10, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone Jun 10, 2022
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 221e4b3 into mars-project:master Jun 10, 2022
v0.10 Release automation moved this from PR-In progress to PR-Done Jun 10, 2022
Ray DAG Execution Backend automation moved this from In Progress to Done Jun 10, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Jun 12, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants