Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate special error functions #3060

Merged
merged 4 commits into from
May 23, 2022
Merged

Integrate special error functions #3060

merged 4 commits into from
May 23, 2022

Conversation

RandomY-2
Copy link
Contributor

@RandomY-2 RandomY-2 commented May 22, 2022 •
edited
Loading

What do these changes do?

Integrate special error functions (erfc, erfcx, erfi, erfinv, erfcinv) following the erf function example

Related issue number

#757 (error functions part)

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@RandomY-2 RandomY-2 requested a review from a team as a code owner May 22, 2022 23:35
@wjsi
Copy link
Member

wjsi commented May 23, 2022 •
edited
Loading

Thank you for your contribution! Please click on checkboxes in PR description once you've fulfilled these requrements.
implement_scipy decorator actually copies documents from scipy, thus it is not needed to add docs manually in sources.
Also remember to add doc entries in docs/source/reference/tensor/special.rst.

@wjsi wjsi added mod: tensor type: feature New feature to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
@wjsi wjsi added this to In progress in Tensor via automation May 23, 2022
@wjsi wjsi added this to PR-In progress in v0.10 Release via automation May 23, 2022
wjsi
wjsi approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi changed the title Integrate Special Error Functions Integrate special error functions May 23, 2022
hekaisheng
hekaisheng approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tensor automation moved this from In progress to Reviewer approved May 23, 2022
@hekaisheng hekaisheng merged commit baafbe4 into mars-project:master May 23, 2022
Tensor automation moved this from Reviewer approved to Done May 23, 2022
v0.10 Release automation moved this from PR-In progress to PR-Done May 23, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 23, 2022
@RandomY-2 @wjsi
Integrate special error functions (mars-project#3060)
0f058dc
@wjsi wjsi mentioned this pull request May 23, 2022
Merged
hekaisheng pushed a commit that referenced this pull request May 23, 2022
@wjsi @RandomY-2
[BACKPORT] Integrate special error functions (#3060)
7b8068c 
Co-authored-by: RandomY-2 <[email protected]>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
@RandomY-2 RandomY-2 deleted the error-functions branch May 23, 2022 15:59
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: tensor type: feature New feature
Projects
Tensor
  
Done
v0.10 Release
PR-Done
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RandomY-2 @wjsi @hekaisheng @qinxuye