Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunk index error in auto_merge_chunks #3057

Merged
merged 1 commit into from
May 23, 2022

Conversation

yuyiming
Copy link
Collaborator

What do these changes do?

if a single chunk remains to merge in auto_merge_chunks, current code tries not to create a new concat OP and just use the last chunk. But the index of last chunk should be changed after merging.

This PR fixes this issue.

Related issue number

Fixes #3056

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@yuyiming yuyiming requested a review from a team as a code owner May 20, 2022 08:30
@yuyiming yuyiming added the type: bug Something isn't working label May 20, 2022
@hekaisheng hekaisheng added mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels May 20, 2022
@hekaisheng hekaisheng added this to PR-In progress in v0.10 Release via automation May 20, 2022
@hekaisheng hekaisheng added this to In progress in DataFrame via automation May 20, 2022
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng added this to the v0.10.0a1 milestone May 20, 2022
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved May 23, 2022
@hekaisheng hekaisheng merged commit d3d608c into mars-project:master May 23, 2022
DataFrame automation moved this from Reviewer approved to Done May 23, 2022
v0.10 Release automation moved this from PR-In progress to PR-Done May 23, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 23, 2022
wjsi added a commit that referenced this pull request May 23, 2022
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] wrong index of the last chunk after auto merging
4 participants