Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray] Implements get_chunks_meta for Ray execution context #3052

Merged
merged 6 commits into from
May 20, 2022
Merged

[Ray] Implements get_chunks_meta for Ray execution context #3052

merged 6 commits into from
May 20, 2022

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented May 19, 2022 •
edited
Loading

What do these changes do?

  • Implement get_chunks_meta for Ray execution context.
  • Add memory_size meta for auto_merge_chunks.
  • Empty implements these APIs for Ray execution context:
    • new_custom_log_dir
    • register_custom_log_path
    • set_progress
    • set_running_operand_key
    • get_storage_info

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone added this to In Progress in Ray DAG Execution Backend via automation May 19, 2022
@fyrestone fyrestone self-assigned this May 19, 2022
刘宝 added 2 commits May 19, 2022 14:24
@fyrestone fyrestone marked this pull request as ready for review May 19, 2022 07:33
@fyrestone fyrestone requested a review from a team as a code owner May 19, 2022 07:33
@fyrestone fyrestone changed the title [Ray] Implement get_chunks_meta for Ray executor [Ray] Implement get_chunks_meta for Ray execution context May 19, 2022
chaokunyang
chaokunyang approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrestone fyrestone changed the title [Ray] Implement get_chunks_meta for Ray execution context [Ray] Implements get_chunks_meta for Ray execution context May 20, 2022
qinxuye
qinxuye approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit aa23fd0 into mars-project:master May 20, 2022
Ray DAG Execution Backend automation moved this from In Progress to Done May 20, 2022
@qinxuye qinxuye added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch labels May 20, 2022
@qinxuye qinxuye added this to PR-In progress in v0.10 Release via automation May 20, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 20, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request May 24, 2022
@fyrestone @wjsi
[Ray] Implements get_chunks_meta for Ray execution context (mars-proj…
fe409c3 
…ect#3052)
@wjsi wjsi mentioned this pull request May 24, 2022
Merged
wjsi added a commit that referenced this pull request May 24, 2022
@wjsi @fyrestone
[BACKPORT][Ray] Implements get_chunks_meta for Ray execution context (#…
dfd0bdb 
…3052) (#3076)

Co-authored-by: Liu Bao <[email protected]>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees

@fyrestone fyrestone

Labels
backported already PR has been backported mod: task service type: enhancement request
Projects
Ray DAG Execution Backend
Done
v0.10 Release
PR-In progress
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fyrestone @qinxuye @chaokunyang @wjsi