[Ray] Fix ray executor progress test #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
reviewed
May 13, 2022
|
|
||
| t1 = t.sum() | ||
| r = t1.map_chunk(f1) | ||
| info = await session.execute(r) |
There was a problem hiding this comment.
How long does this test case take? I noticed that there is a time.sleep(2) in the f1.
There was a problem hiding this comment.
It takes about 5s on mars executor, 10s on ray executor.
There was a problem hiding this comment.
Can you make it faster? Ray backend is slower because:
- import ray
- start ray cluster
- ray kill idle worker (we can config
kill_idle_workers_interval_msto 0, please refer to https://github.com/ray-project/ray/blob/master/src/ray/common/ray_config_def.h#L399)
There was a problem hiding this comment.
Thanks for you reminder. I've fixed it. Now its cost is about 6s on ray.
qinxuye
added
type: bug
|
@fyrestone Could you please review this PR to see if there is any further issue? |
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
May 23, 2022
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Ray executor progress test does not run due to lack of await. This pr fixed it.
Related issue number
Fixes #xxxx
Check code requirements