Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray] Implements get_chunks_result for Ray execution context #3023

Merged
merged 14 commits into from
May 13, 2022
Merged

[Ray] Implements get_chunks_result for Ray execution context #3023

merged 14 commits into from
May 13, 2022

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented May 11, 2022 •
edited
Loading

What do these changes do?

  • Implement theget_chunks_result API for Ray execution context.
  • Fix remote object may be called before creation.
  • Add ray_dag CI, then we can use @pytest.mark.ray_dag to mark the test case run in ray backend.

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this May 11, 2022
@fyrestone fyrestone marked this pull request as ready for review May 12, 2022 07:49
@qinxuye qinxuye changed the title [Ray] get_chunks_result for Ray execution context [Ray] Implements get_chunks_result for Ray execution context May 12, 2022
@qinxuye qinxuye added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: ray integration mod: task service labels May 12, 2022
@qinxuye qinxuye added this to PR-In progress in v0.10 Release via automation May 12, 2022
@qinxuye qinxuye added this to the v0.10.0a1 milestone May 12, 2022
chaokunyang
chaokunyang approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrestone fyrestone added this to In Progress in Ray DAG Execution Backend via automation May 13, 2022
qinxuye
qinxuye approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 6c9c4b0 into mars-project:master May 13, 2022
v0.10 Release automation moved this from PR-In progress to PR-Done May 13, 2022
Ray DAG Execution Backend automation moved this from In Progress to Done May 13, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request May 16, 2022
@fyrestone
[Ray] Implements get_chunks_result for Ray execution context (mars-pr…
cfb8455 
…oject#3023)
wjsi pushed a commit to wjsi/mars that referenced this pull request May 23, 2022
@fyrestone @wjsi
[Ray] Implements get_chunks_result for Ray execution context (mars-pr…
20d61b4 
…oject#3023)
@wjsi wjsi mentioned this pull request May 23, 2022
Merged
wjsi added a commit that referenced this pull request May 24, 2022
@wjsi @fyrestone
[BACKPORT][Ray] Implements get_chunks_result for Ray execution context (
048dad3 
#3023) (#3072)

Co-authored-by: Liu Bao <[email protected]>
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

@wjsi wjsi Awaiting requested review from wjsi

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees

@fyrestone fyrestone

Labels
backported already PR has been backported mod: ray integration mod: task service type: enhancement request
Projects
Ray DAG Execution Backend
Done
v0.10 Release
PR-Done
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fyrestone @qinxuye @chaokunyang @wjsi