Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msg_to_simple_str in Ray backend and add tests #3003

Merged
merged 1 commit into from
May 6, 2022

Conversation

chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented May 6, 2022

What do these changes do?

This PR fix msg_to_simple_str error introduced in #2936 when truth value for some object is ambiguous.
image

Related issue number

#2936

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

Copy link
Contributor

@Catch-Bull Catch-Bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye changed the title fix msg_to_simple_str and add tests Fix msg_to_simple_str and add tests May 6, 2022
@wjsi wjsi changed the title Fix msg_to_simple_str and add tests Fix msg_to_simple_str in Ray backend and add tests May 6, 2022
@qinxuye qinxuye added the type: bug Something isn't working label May 6, 2022
@qinxuye qinxuye added this to In progress in Misc via automation May 6, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation May 6, 2022
@qinxuye qinxuye added this to the v0.9.0rc3 milestone May 6, 2022
@qinxuye qinxuye merged commit 9ffacce into mars-project:master May 6, 2022
Misc automation moved this from In progress to Done May 6, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Misc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants