Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray] Loads the subtask inputs from meta #2976

Merged
merged 4 commits into from
Apr 28, 2022
Merged

[Ray] Loads the subtask inputs from meta #2976

merged 4 commits into from
Apr 28, 2022

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented Apr 27, 2022 •
edited
Loading

What do these changes do?

This PR makes the Ray executor able to load the subtask inputs from meta, so Ray backend can run the task which inputs are the executed tasks.

Related issue number

#2893

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Apr 27, 2022
@fyrestone fyrestone marked this pull request as ready for review April 27, 2022 12:38
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Apr 28, 2022
@qinxuye qinxuye added this to the v0.9.0rc3 milestone Apr 28, 2022
qinxuye
qinxuye approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit dddc201 into mars-project:master Apr 28, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Apr 28, 2022
@fyrestone fyrestone added this to In Progress in Ray DAG Execution Backend via automation May 13, 2022
@fyrestone fyrestone moved this from In Progress to Done in Ray DAG Execution Backend May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng

Assignees

@fyrestone fyrestone

Labels
mod: ray integration mod: task service type: enhancement request
Projects
Ray DAG Execution Backend
Done
v0.9 Release
PR-Done
Milestone
v0.9.0rc3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fyrestone @qinxuye @wjsi