-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Add metrics on operand and subtask executions #2947
Conversation
* Add scheduling, band and op metrics * Optimize metrics arguments check
4cf6872
to
9313cb1
Compare
Some metrics named with suffix |
Thanks for you suggestion. |
OK, can we have a document about the naming specification about metrics? Just add it to https://github.com/mars-project/mars/tree/master/docs/source/development ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, like I said, we can add a document about adding metrics.
Ok, I'll add docs soon. |
Added in #2955, please take a look. |
@@ -39,6 +40,11 @@ | |||
_op_type_to_size_estimator: Dict[Type[OperandType], Callable] = dict() | |||
|
|||
|
|||
op_executed_number = Metrics.counter( | |||
"mars.operand.executed_number", "The number of executed operands.", ("op",) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of what kind of objects executed? Please make the name of the counter and the variable more explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about mars.operator_executed_number
? And the description is The number of executed operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I've ignored the prefix.. Already merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
Related issue number
Fixes #xxxx
Check code requirements