Implementing Ellipsoidal Harmonics Functions

[shantam-8]

What do these changes do?

The changes are meant to implement the ellipsoidal harmonics functions present in the Scipy library in tensor special.

Related issue number

Fixes #758

Check code requirements

• tests added / passed (if needed)
• Ensure all linting tests pass, see here for how to run them

[qinxuye]

Could you please add a test to https://github.com/mars-project/mars/blob/master/mars/tensor/special/tests/test_special_execution.py

And you can add a test_quintuple_execution and refer to the the other tests.

[shantam-8]

Hello @qinxuye, @hekaisheng, and @wjsi, I hope you all are doing well. I have created the tests but they are currently failing (as seen in the attached picture for ellip_normal). Also, I noticed that the scipy ellipsoidal harmonics functions only take float and/or int as inputs. Could you please tell me how should I go about solving it? Thanks in advance!

[qinxuye]

Hello @qinxuye, @hekaisheng, and @wjsi, I hope you all are doing well. I have created the tests but they are currently failing (as seen in the attached picture for ellip_normal). Also, I noticed that the scipy ellipsoidal harmonics functions only take float and/or int as inputs. Could you please tell me how should I go about solving it? Thanks in advance!

Yeah, the functions ellip_normal etc cannot accept order argument, one solution is that you can overwrite the execute_cpu method to stop passing order to the argument.

You can refer to the execute_gpu method, the gpu function cannot pass order either.

mars/mars/tensor/special/core.py

Lines 64 to 68 in 7732192

	def _execute_gpu(cls, op, xp, *args, **kw):
	if kw.get("out") is not None:
	kw["out"] = xp.asarray(kw["out"])
	r = cls._get_func(xp)(*args, **kw)
	return convert_order(r, op.outputs[0].order.value)

[shantam-8]

Hello @qinxuye, I have rewritten the execute_cpu function based on execute_gpu function. This ensures that order is not passed as an argument to the ellip harmonic functions. However, I had to add an isfortran function in innit.py to ensure that the execute_cpu function passes. However, the tests are still failing, as seen in the attached picture. Could you please tell me how to solve that?

[qinxuye]

@shantam-8 Let me see what's happening.

[wjsi]

LGTM

[qinxuye]

@shantam-8 , @wjsi has addressed the issue for you, basically modified _execute_cpu.

[qinxuye]

LGTM

[qinxuye]

Thanks, look forward to seeing more contributions from you.