Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout for wait_task #2883

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Fix timeout for wait_task #2883

merged 3 commits into from
Mar 31, 2022

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

Use tornado.gen.with_timeout to fix request timeout.

Related issue number

Fixes #2882

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: web to be backported Indicate that the PR need to be backported to stable branch labels Mar 29, 2022
@hekaisheng hekaisheng added this to the v0.9.0rc2 milestone Mar 29, 2022
@hekaisheng hekaisheng added this to In progress in Distributed via automation Mar 29, 2022
@hekaisheng hekaisheng requested a review from wjsi as a code owner March 29, 2022 10:05
@hekaisheng hekaisheng added this to PR-In progress in v0.9 Release via automation Mar 29, 2022
@hekaisheng
Copy link
Contributor Author

I can debug into the uncovered code on local, coverage issue can be ignored.

wjsi
wjsi reviewed Mar 31, 2022
View reviewed changes
mars/services/task/api/web.py Outdated Show resolved Hide resolved
mars/services/task/api/web.py Outdated Show resolved Hide resolved
wjsi
wjsi approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit f702803 into mars-project:master Mar 31, 2022
Distributed automation moved this from In progress to Done Mar 31, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Mar 31, 2022
@qinxuye qinxuye deleted the bugfix/timeout branch March 31, 2022 10:36
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Mar 31, 2022
@hekaisheng
Fix timeout for wait_task (mars-project#2883)
f451626 
(cherry picked from commit f702803)
@hekaisheng hekaisheng mentioned this pull request Mar 31, 2022
Merged
wjsi pushed a commit that referenced this pull request Apr 1, 2022
@hekaisheng
[BACKPORT] Fix timeout for wait_task (#2883) (#2890)
68060e2
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: web type: bug Something isn't working
Projects
Distributed
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0rc2
Development

Successfully merging this pull request may close these issues.

[BUG] wait_task raises TimeoutError while task is executing
3 participants
@hekaisheng @qinxuye @wjsi