Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileSystem.ls for OSS #2837

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix FileSystem.ls for OSS #2837

merged 1 commit into from
Mar 18, 2022

Conversation

hekaisheng
Copy link
Contributor

@hekaisheng hekaisheng commented Mar 18, 2022 •
edited
Loading

What do these changes do?

  • Fix FileSystem.ls for OSS
  • Rename some variables in OptimizationRule

Related issue number

Fixes #2835

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working to be backported Indicate that the PR need to be backported to stable branch labels Mar 18, 2022
@hekaisheng hekaisheng added this to the v0.9.0rc1 milestone Mar 18, 2022
@hekaisheng hekaisheng requested a review from wjsi as a code owner March 18, 2022 09:21
@hekaisheng hekaisheng added this to In progress in Misc via automation Mar 18, 2022
@hekaisheng hekaisheng added this to PR-In progress in v0.9 Release via automation Mar 18, 2022
wjsi
wjsi approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Mar 18, 2022
@qinxuye qinxuye merged commit 85fcf72 into mars-project:master Mar 18, 2022
Misc automation moved this from Reviewer approved to Done Mar 18, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Mar 18, 2022
@qinxuye qinxuye deleted the bugfix/oss-ls branch March 18, 2022 11:46
wjsi pushed a commit to wjsi/mars that referenced this pull request Mar 20, 2022
@hekaisheng @wjsi
Fix FileSystem.ls for OSS (mars-project#2837)
b1185fe
@wjsi wjsi mentioned this pull request Mar 20, 2022
Merged
qinxuye pushed a commit that referenced this pull request Mar 20, 2022
@wjsi
[BACKPORT] Enhance subtask details in logs (#2836) and fix FileSystem…
f57ecda 
….ls for OSS (#2837)  (#2842)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: bug Something isn't working
Projects
Misc
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0rc1
Development

Successfully merging this pull request may close these issues.

[BUG] Read files from oss failed
3 participants
@hekaisheng @qinxuye @wjsi