Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docker images cronically #2804

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Build docker images cronically #2804

merged 1 commit into from
Mar 10, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 10, 2022

What do these changes do?

Build docker images at 18:00 UTC every day to reduce redundant images. If no commits last day, build will be skipped.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added this to the v0.9.0rc1 milestone Mar 10, 2022
@wjsi wjsi added this to In progress in Misc via automation Mar 10, 2022
@wjsi wjsi added this to PR-In progress in v0.9 Release via automation Mar 10, 2022
qinxuye
qinxuye approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Mar 10, 2022
@hekaisheng hekaisheng merged commit f7578b0 into mars-project:master Mar 10, 2022
Misc automation moved this from Reviewer approved to Done Mar 10, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Mar 10, 2022
@wjsi wjsi added the to be backported Indicate that the PR need to be backported to stable branch label Mar 10, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 10, 2022
@wjsi
Try adding cron docker build (mars-project#2804)
9224f40
@wjsi wjsi mentioned this pull request Mar 10, 2022
Merged
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: tests
Projects
Misc
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjsi @qinxuye @hekaisheng