Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cibuildwheel with Linux AArch64 wheel build support #2672

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jan 31, 2022

Added cibuildwheel with linux aarch64 wheel build support.
Related to #2660, @wjsi Could you please review this PR?

@wjsi
Copy link
Member

wjsi commented Feb 1, 2022

Thank you for the commit! I have several questions.

  1. We already have a pypi deploy pipeline, you need to replace it.
  2. Limiting versions of numpy is to make sure our builds are compatible with older numpy c-api versions. Please do not change these settings.
  3. We also need x86_64 releases for macOS and Windows. Seems that OS matrix ignore them.
  4. Seems that joerick/cibuildwheel redirects to pypa/cibuildwheel, why not use the official one?
  5. When uploading wheels, upload to test.pypi.org when we are not under repo mars-project/mars, just as what we've done in this bash script.
  6. Select an OS arch to upload source package along with wheels, just as what we've done in this bash script.

@odidev
Copy link
Contributor Author

odidev commented Feb 4, 2022

Did the changes as required.
As for the changes in the requirements file, since the older versions of some packages do not have aarch64 wheel available, higher versions are required for the same.

@wjsi
Copy link
Member

wjsi commented Feb 6, 2022

Did the changes as required. As for the changes in the requirements file, since the older versions of some packages do not have aarch64 wheel available, higher versions are required for the same.

These version requirements cannot be changed as we really need to support environments with old versions of numpy. Add arch-specific conditons may be specified with platform_machine=='aarch64' condition and a fixed version.

Other dependencies for wheel building in ci directory, for instance, build-wheels.sh and upload-packages.sh, can be removed now.

.github/workflows/pypi-cd.yml Outdated Show resolved Hide resolved
.github/workflows/pypi-cd.yml Outdated Show resolved Hide resolved
.github/workflows/pypi-cd.yml Outdated Show resolved Hide resolved
.github/workflows/pypi-cd.yml Outdated Show resolved Hide resolved
@odidev
Copy link
Contributor Author

odidev commented Feb 8, 2022

Done.

@wjsi wjsi added this to In progress in Misc via automation Feb 9, 2022
@wjsi wjsi added this to PR-In progress in v0.9 Release via automation Feb 9, 2022
@wjsi wjsi added this to the v0.9.0b1 milestone Feb 9, 2022
@wjsi
Copy link
Member

wjsi commented Feb 9, 2022

I made some modifications on dependency versions and tested on my own repo. Produced packages seems working. Wait for all CI finished and I will approve it.

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your commit!

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved Feb 9, 2022
@qinxuye qinxuye merged commit aaa23e8 into mars-project:master Feb 9, 2022
Misc automation moved this from Reviewer approved to Done Feb 9, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 9, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
wjsi added a commit to wjsi/mars that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Misc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants