Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray] Refine raydataset integration #2579

Merged

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

Refine mars and ray dataset integration:

  • Refine to_ray_dataset/to_ray_mldataset implementation
  • Add MLDataset read operator
  • Add XGB integration test cases
  • Upgrade ray and xgb versions.

Related issue number

#2112

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang force-pushed the refine_raydataset_integration branch 3 times, most recently from 8a2dac8 to 049145f Compare November 17, 2021 08:25
wjsi
wjsi previously approved these changes Nov 18, 2021
wjsi
wjsi previously approved these changes Nov 19, 2021
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some prints could be removed.

mars/dataframe/contrib/raydataset/tests/test_mldataset.py Outdated Show resolved Hide resolved
reg = RayXGBRegressor(ray_params=ray_params, random_state=42)
# train
reg.fit(RayDMatrix(ds, "target"), y=None, ray_params=ray_params)
print(f"Regressor {reg}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Nov 20, 2021
@qinxuye qinxuye added this to the v0.9.0a1 milestone Nov 20, 2021
@qinxuye qinxuye merged commit 7ad7e03 into mars-project:master Nov 20, 2021
v0.9 Release automation moved this from PR-In progress to PR-Done Nov 20, 2021
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Feb 15, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Feb 15, 2022
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mars on Ray
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants