Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index series.apply when result index unchanged #2557

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix index series.apply when result index unchanged #2557

merged 1 commit into from
Oct 28, 2021

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Oct 28, 2021

What do these changes do?

Fix index series.apply when result index unchanged.

Related issue number

Fixes #2556

@wjsi wjsi added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Oct 28, 2021
@wjsi wjsi added this to the v0.9.0a1 milestone Oct 28, 2021
@wjsi wjsi added this to In progress in DataFrame via automation Oct 28, 2021
hekaisheng
hekaisheng approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved Oct 28, 2021
@qinxuye qinxuye merged commit bf147c5 into mars-project:master Oct 28, 2021
DataFrame automation moved this from Reviewer approved to Done Oct 28, 2021
@wjsi wjsi deleted the bugfix/apply_index branch October 28, 2021 15:44
wjsi added a commit to wjsi/mars that referenced this pull request Oct 28, 2021
@wjsi
Fix index series.apply when result index unchanged (mars-project#2557)
958801f
@wjsi wjsi mentioned this pull request Oct 28, 2021
Merged
qinxuye pushed a commit that referenced this pull request Oct 29, 2021
@wjsi
[BACKPORT] Fix index series.apply when result index unchanged (#2557) (…
ccfaf01 
…#2563)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
Milestone
v0.9.0a1
Development

Successfully merging this pull request may close these issues.

When using results from series.apply, unnecessary reindex produced
3 participants
@wjsi @qinxuye @hekaisheng